Fix(GraphQL): Fix duplicate XID error in case of interface XIDs #7776
+279
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/graphql
vmrajas
commented
May 6, 2021
| @@ -2741,43 +2743,6 @@ | |||
| message: |- | |||
| failed to rewrite mutation payload because duplicate XID found: S1 | |||
|
|
|||
| - name: "Duplicate XIDs in single mutation for Interface" | |||
There was a problem hiding this comment.
Removed this test as it was wrong. As xid does not have interface=true flag. It is perfectly fine to have Student and Teacher with same xid.
vmrajas
commented
May 6, 2021
| @@ -1457,48 +1457,6 @@ | |||
| message: |- | |||
| failed to rewrite mutation payload because duplicate XID found: T1 | |||
|
|
|||
| - name: "Duplicate XIDs in single mutation for Interface" | |||
There was a problem hiding this comment.
Removed this test as it was wrong. As xid does not have interface=true flag. It is perfectly fine to have Student and Teacher with same xid.
abhimanyusinghgaur
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation:
This PR adds the implementing type name to the key. This ensures that different variable names are generated for different implementing types of the same interface with same XID (name and value). It also adds an error condition to give error in case two nodes of different types with same XID(with interface=true) flag are added.
It also fixes other bug related to referencing same node with multiple IDs in same mutation.
Testing:
Added yaml and e2e tests.
Note that two tests from yaml tests have been removed as they were wrong.
Fixes GRAPHQL-1164
This change is